Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: FileReadObservation.init() got an unexpected keyword argument 'impl_source' #5741

Open
1 task done
avi12 opened this issue Dec 21, 2024 · 20 comments · May be fixed by #5972
Open
1 task done

[Bug]: FileReadObservation.init() got an unexpected keyword argument 'impl_source' #5741

avi12 opened this issue Dec 21, 2024 · 20 comments · May be fixed by #5972
Labels
backend Related to backend bug Something isn't working fix-me-experimental

Comments

@avi12
Copy link

avi12 commented Dec 21, 2024

Is there an existing issue for the same bug?

  • I have checked the existing issues.

Describe the bug and reproduction steps

https://www.all-hands.dev/share?share_id=89cc5c6565e8372271be4bb803ec6eff0cee8201800be7514a63500edda88490

OpenHands Installation

Docker command in README

OpenHands Version

0.16.1

Operating System

WSL on Windows

Logs, Errors, Screenshots, and Additional Context

No response

@avi12 avi12 added the bug Something isn't working label Dec 21, 2024
@malhotra5
Copy link
Contributor

+1 on this (Workflow log)

image

@avi12
Copy link
Author

avi12 commented Dec 22, 2024

It seems like this particular issue was solved with the bot's update

@avi12 avi12 closed this as completed Dec 22, 2024
@malhotra5
Copy link
Contributor

Reopening this issue, still facing the issue on main

Sample workflow log

@malhotra5 malhotra5 reopened this Dec 22, 2024
@malhotra5 malhotra5 added the fix-me Attempt to fix this issue with OpenHands label Dec 22, 2024
@enyst
Copy link
Collaborator

enyst commented Dec 22, 2024

To note, this looks like a version conflict:

image

@malhotra5
Copy link
Contributor

malhotra5 commented Dec 22, 2024

Ah gotcha, how about this workflow log? It's using main but faced the same error

@enyst
Copy link
Collaborator

enyst commented Dec 22, 2024

It looks like this is not main, it's 0.16.1... 🤔

@enyst
Copy link
Collaborator

enyst commented Dec 22, 2024

I mean line 139 there

@malhotra5
Copy link
Contributor

malhotra5 commented Dec 22, 2024

Ah I see the confusion - the previous step in the workflow checks for the latest version

image

However for the step that installs the package, I forced it to install from main
image

When I use the released version 0.16.1, this issue doesn't occur (another workflow log
)

It seems like this is an issue only on main

EDIT: we can confirm this by running fix-me vs fix-me-experimental on an issue; I believe fix-me-experimental will fail

@All-Hands-AI All-Hands-AI deleted a comment from openhands-agent Dec 22, 2024
@All-Hands-AI All-Hands-AI deleted a comment from openhands-agent Dec 22, 2024
@enyst
Copy link
Collaborator

enyst commented Dec 22, 2024

Hmm, how about the sandbox? This code above is running in the sandbox 🤔

@malhotra5
Copy link
Contributor

malhotra5 commented Dec 22, 2024

I believe the resolver runs on eventstream instead of sandbox runtime; am I interpreting this correctly?

EDIT: yeah its running on a sandbox
image

@enyst
Copy link
Collaborator

enyst commented Dec 22, 2024

The "eventstream runtime" is a docker sandbox, which communicates using an API sending/receiving events from the sandbox. It's not local, it's in docker.

EDIT: we can confirm this by running fix-me vs fix-me-experimental on an issue; I believe fix-me-experimental will fail

I ran fix-me-experimental here last night, it worked. The difference might be that your test repo is an external repo, while the successful workflow worked on this repo?

@malhotra5 malhotra5 added fix-me-experimental and removed fix-me Attempt to fix this issue with OpenHands labels Dec 22, 2024
@openhands-agent
Copy link
Contributor

OpenHands started fixing the issue! You can monitor the progress here.

@malhotra5
Copy link
Contributor

Possibly! Did a quick test, was able to reproduce the error again on this repo; there may be a PR that caused a regression in the last day or so

@enyst
Copy link
Collaborator

enyst commented Dec 22, 2024

Oh, it failed with the same error. 🫣

Line 36: https://github.com/All-Hands-AI/OpenHands/actions/runs/12455745077/job/34768492590#step:10:37

@ryanhoangt
Copy link
Contributor

ryanhoangt commented Dec 23, 2024

I think the issue is due to the resolver using a specified runtime image, which skipped the runtime image build process:

if runtime_container_image is None:
runtime_container_image = (
f'ghcr.io/all-hands-ai/runtime:{openhands.__version__}-nikolaik'
)

One way to address might be to not specify this runtime image at all, similar to the dev workflow, which can add some build time overhead to the resolver, but can keep it up to date with all the changes in main. What do you guys think?

@glgh
Copy link

glgh commented Dec 23, 2024

I'm running into the same issue running openhands locally using the development flow. My repo was synced to ee5f49a

@gordicaleksa
Copy link

+1

I'll revert to the last known stable commit as i'm just getting familiar with the project :)

@enyst
Copy link
Collaborator

enyst commented Dec 26, 2024

I think the issue is due to the resolver using a specified runtime image, which skipped the runtime image build process:

if runtime_container_image is None:
runtime_container_image = (
f'ghcr.io/all-hands-ai/runtime:{openhands.__version__}-nikolaik'
)

One way to address might be to not specify this runtime image at all, similar to the dev workflow, which can add some build time overhead to the resolver, but can keep it up to date with all the changes in main. What do you guys think?

Aha, that was the code. I agree! I think we should fix it as you suggest: let it build the runtime it needs.

Because we now use main in our fairly regularly used workflow, and also, importantly, other repos also build on top of our main workflow. Conflicts like this between the sandbox image and main can be pretty bad and they're almost blocking for external workflows.

Please note that this isn't always: this is for fix-me-experimental and equivalent macro (at openhands-agent-exp), which run on main. For the rest, the regular fix-me workflow (and equivalent macro), we can keep the released runtime, so there are no build times concerns there. Those run on the pypi version.

@enyst
Copy link
Collaborator

enyst commented Dec 26, 2024

@glgh @gordicaleksa If you encounter this without running the resolver, can you please remove all openhands-related images from docker, and let it re-download?

@ryanhoangt
Copy link
Contributor

ryanhoangt commented Dec 26, 2024

@enyst Yeah, let me have a closer look and try a PR for that. This is a good opportunity for me to learn more about the resolver! 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Related to backend bug Something isn't working fix-me-experimental
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants