Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed typo on string 137 #2966

Merged
merged 1 commit into from
May 13, 2019
Merged

Fixed typo on string 137 #2966

merged 1 commit into from
May 13, 2019

Conversation

kant
Copy link
Contributor

@kant kant commented Apr 4, 2019

Description

Fixed typo on string 137, plus some translation done

Issue fixed

There is no previous issue fixed. There is no break on code.

Type of changes

  • ⚪ Bug fix (Change that fixed an issue)
  • ⚪ Breaking change (Change that can cause existing functionality to change)
  • ⚪ Improvement (Change that improves the code. Maybe performance or development improvement)
  • ⚪ Feature (Change that adds new functionality)
  • 🔘 Documentation change (Change that modifies documentation. Maybe typo fixes)

Checklist:

  • 🔘 My code follows the project code style
  • 🔘 I have written test for my code and it has been tested
  • 🔘 All existing tests have been passed
  • ⚪ I have attached a screenshot/video to visualize my change if possible

@kant
Fixed typo on string 137
9dcecf6 
* plus some translations added
@ZeroX-DG ZeroX-DG added the awaiting review ❇️ Pull request is awaiting a review. label Apr 4, 2019
@ZeroX-DG ZeroX-DG added the help wanted 🆘 Pull request/issue requires extra help from the community. Check these out if you're new! label Apr 13, 2019
@ZeroX-DG
Copy link
Member

Is there anyone else who can review this PR and confirm your translation?

Canopix
Canopix approved these changes May 8, 2019
View reviewed changes
Copy link

@Canopix Canopix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The translation is fine!

@ZeroX-DG
Copy link
Member

@Rokt33r You can merge it now.

@ZeroX-DG ZeroX-DG added approved 👍 Pull request has been approved by sufficient reviewers. and removed help wanted 🆘 Pull request/issue requires extra help from the community. Check these out if you're new! awaiting review ❇️ Pull request is awaiting a review. labels May 11, 2019
@Rokt33r Rokt33r merged commit 079aaec into BoostIO:master May 13, 2019
@Rokt33r Rokt33r removed the approved 👍 Pull request has been approved by sufficient reviewers. label May 13, 2019
@Rokt33r Rokt33r added this to the v0.11.15 milestone May 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Canopix Canopix Canopix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.11.16
Development

Successfully merging this pull request may close these issues.
4 participants
@kant @ZeroX-DG @Canopix @Rokt33r