Fix theme path issue #3048

AWolf81 · 2019-05-30T07:45:43Z

Description

Changed path usage with-out ../
Change development check on process.env - not perfect but that way we're getting production stuff if NODE_ENV is not defined. I think we can fix / improve that once we improved the build process.

Interface theming had a path issue as mentioned in the issue.
Editor theming should be fixed as well.

Issue fixed

#3018, #3042

Type of changes

🔘 Bug fix (Change that fixed an issue)
⚪ Breaking change (Change that can cause existing functionality to change)
⚪ Improvement (Change that improves the code. Maybe performance or development improvement)
⚪ Feature (Change that adds new functionality)
⚪ Documentation change (Change that modifies documentation. Maybe typo fixes)

Checklist:

🔘 My code follows the project code style
⚪ I have written test for my code and it has been tested
🔘 All existing tests have been passed
🔘 I have attached a screenshot/video to visualize my change if possible

Screenshot

Error message

Questions / notes

Please double check the editor theming.
Error message (see screenshot) - why do I get it?

Tested

LinuxMint 19.1 (4.15.0-50 Linux) - Dev server & binary - theme switching OK
Windows 10 64bit - Dev server & binary - theme switching OK
MacOs High Sierra (10.13.6) - Theme switching OK - tested by incredibleweirdo

AWolf81 · 2019-05-30T12:35:04Z

Seems like there is an issue on Linux. Tested with Ubuntu 18 and css not found - I need to do more debugging here.

Update
Fixed theming for Linux binary. I couldn't test the dev server in Ubuntu because it wasn't starting - no error it was just the stopped loading spinner. Will check this later.

incredibleweirdo · 2019-05-30T21:45:51Z

Hello,
I have tested on Windows 7 and macOS High Sierra (10.13.6), and can confirm themes now work as intended.
As I was guessing this was related to #2968 based on the fix discussed in #3018 making export usable, I tested that as well and found it is now solved in Windows 7 with this change; but still broken in macOS. I can capture console output and screenshots if that is helpful.

Edited to add:
I believe this breaks export on macOS.
If I yarn run dev from master or v0.11.16, I'm able to export on macOS without issue. With the branch from this PR, export on macOS does not work.
However, themes do work as expected, but themes also work on macOS before this change in my testing.

On Windows 7, master and v0.11.16 have the bug with themes not working, AND have export not working. The branch from this PR have themes working and export working.

I have a Linux machine at home I can test with tomorrow.

incredibleweirdo · 2019-05-30T22:26:44Z

browser/components/MarkdownPreview.js

-      return `${appPath}/node_modules/codemirror/theme/elegant.css`
-    }
+    return theme
+      ? (win ? theme.path : `../${theme.path}`)


I think this is what it needs to be for macOS:

Suggested change

? (win ? theme.path : `../${theme.path}`)

? (win ? theme.path : `${appPath}/${theme.path}`)

OK, changed this & tested it with Ubuntu binary. Theming (Editor, in preview code block & app theme) is working.

AWolf81 · 2019-05-31T08:47:52Z

browser/main/lib/ConfigManager.js

@@ -141,7 +140,7 @@ function get () {
    const theme = consts.THEMES.find(theme => theme.name === config.editor.theme)

    if (theme) {
-      editorTheme.setAttribute('href', `../${theme.path}`)
+      editorTheme.setAttribute('href', win ? theme.path : `../${theme.path}`)


@incredibleweirdo Is this working on Mac? Just wondering because if the other change in MarkdownPreview was required then we should change every occurence from ../ to the absolute path.
But if it's working we can also keep it.

Yeah, changing themes appears to work fine.

amedora · 2019-06-11T00:21:10Z

tested on Win7/64 and confirmed that problems described in #3018 and #3042 has resolved.

Flexo013 · 2019-07-01T14:25:42Z

@Rokt33r Could this pull request be added to the upcoming milestone/release? https://github.com/BoostIO/Boostnote/milestone/6

There are a lot of likes that have been given to issues that would be fixed by this PR, so I think it's only logical for this to have a fairly high priority.

elliptic-shiho · 2019-07-03T13:37:17Z

@Rokt33r Boostnote couldn't boost my work due to this issue... so I hope you to fix this problem with high priority (Yes, This issue can fix by dirty hack, but I'll not to use it because dislike dirty hack).

byegates · 2019-07-22T19:41:48Z

When is this fix (0.12.0) going to be available for public?

Rokt33r · 2019-07-23T03:13:26Z

@byegates tomorrow. :)

AWolf81 added 3 commits May 30, 2019 09:10

change process.env check

46ac4e7

change theme path usage and remove relative path

8888a2f

fix test for Windows (fs.rmdir throws dir not empty error)

0ac9124

AWolf81 added 2 commits May 30, 2019 09:10

fix path Linux

1e3d660

fix app path

e63dbca

incredibleweirdo suggested changes May 30, 2019

View reviewed changes

amedora mentioned this pull request May 31, 2019

Fix #2776 #3051

Closed

path fix for MacOs

57f7299

AWolf81 commented May 31, 2019

View reviewed changes

incredibleweirdo mentioned this pull request May 31, 2019

Replace invalid regex for storage placeholder the export functions #2897

Closed

ZeroX-DG added the awaiting review ❇️ Pull request is awaiting a review. label Jun 2, 2019

AWolf81 mentioned this pull request Jun 2, 2019

Dark theme is gone in Boostnote 0.11.17 #3052

Closed

Flexo013 mentioned this pull request Jun 3, 2019

HTML and PDF export is broken #3054

Closed

amedora mentioned this pull request Jun 4, 2019

apply theme color to slider in MarkdownSplitEditor #3055

Merged

ZeroX-DG assigned Rokt33r Jun 9, 2019

ZeroX-DG requested a review from Rokt33r June 9, 2019 02:14

ZeroX-DG mentioned this pull request Jun 13, 2019

Editor themes aren't working since the new release #3018

Closed

ZeroX-DG added awaiting changes 🖊️ Pull request has been reviewed, but contributor needs to make changes. and removed awaiting review ❇️ Pull request is awaiting a review. labels Jun 13, 2019

amedora mentioned this pull request Jul 1, 2019

Export Error when Exporting PDF #3091

Closed

Rokt33r removed the awaiting changes 🖊️ Pull request has been reviewed, but contributor needs to make changes. label Jul 17, 2019

Rokt33r added this to the v0.12.0 milestone Jul 17, 2019

Rokt33r merged commit 782d71d into BoostIO:master Jul 17, 2019

Flexo013 mentioned this pull request Jul 17, 2019

can not highlight code #3042

Closed

Yablon mentioned this pull request Jul 19, 2019

Could I get a release in which the "export pdf" is good to use ? #3130

Closed

Flexo013 mentioned this pull request Jul 22, 2019

Export failure #3138

Closed

AWolf81 deleted the fix-themes branch July 22, 2019 20:38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix theme path issue #3048

Fix theme path issue #3048

AWolf81 commented May 30, 2019 •

edited

Loading

AWolf81 commented May 30, 2019 •

edited

Loading

incredibleweirdo commented May 30, 2019 •

edited

Loading

incredibleweirdo May 30, 2019

AWolf81 May 31, 2019

AWolf81 May 31, 2019 •

edited

Loading

incredibleweirdo May 31, 2019

amedora commented Jun 11, 2019

Flexo013 commented Jul 1, 2019

elliptic-shiho commented Jul 3, 2019

byegates commented Jul 22, 2019

Rokt33r commented Jul 23, 2019

	? (win ? theme.path : `../${theme.path}`)
	? (win ? theme.path : `${appPath}/${theme.path}`)

Fix theme path issue #3048

Fix theme path issue #3048

Conversation

AWolf81 commented May 30, 2019 • edited Loading

Description

Issue fixed

Type of changes

Checklist:

Screenshot

Questions / notes

Tested

AWolf81 commented May 30, 2019 • edited Loading

incredibleweirdo commented May 30, 2019 • edited Loading

incredibleweirdo May 30, 2019

Choose a reason for hiding this comment

AWolf81 May 31, 2019

Choose a reason for hiding this comment

AWolf81 May 31, 2019 • edited Loading

Choose a reason for hiding this comment

incredibleweirdo May 31, 2019

Choose a reason for hiding this comment

amedora commented Jun 11, 2019

Flexo013 commented Jul 1, 2019

elliptic-shiho commented Jul 3, 2019

byegates commented Jul 22, 2019

Rokt33r commented Jul 23, 2019

AWolf81 commented May 30, 2019 •

edited

Loading

AWolf81 commented May 30, 2019 •

edited

Loading

incredibleweirdo commented May 30, 2019 •

edited

Loading

AWolf81 May 31, 2019 •

edited

Loading