optimize: should highlight any non-empty search query, fix #3164 #3175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hikerpig I think you should allow user to be able to customize this. Because some people would prefer performance more so it would be great if you can add a setting for this 👍 |
|
@ZeroX-DG How about a Though I don't think it's necessary, since this highlight will not change any React vdom. It only operates current editor's CodeMirror instance, add some little highlight overlays ontop of matched contents. |
|
hmm....you're right, we can just leave it as |
ZeroX-DG
added
approved 👍
Rokt33r
removed
the
approved 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Digg a little into the situation that #3164 describes, turns out it has nothing to do with unicode characters.
The original
msg.length < 3threshold may be out of performance concern, but since I don't have that much notes kept, it doesn't seem an issue to me.Type of changes