Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update zh_TW translation of build.md #3414

Merged
merged 2 commits into from
Feb 3, 2020
Merged

Update zh_TW translation of build.md #3414

merged 2 commits into from
Feb 3, 2020

Conversation

xatier
Copy link
Contributor

@xatier xatier commented Jan 5, 2020 •
edited
Loading

Complete translation.
Sync with English version.

[1] https://github.com/BoostIO/Boostnote/blob/master/docs/build.md.

Description

Update zh_TW translation of build.md.

Issue fixed

Type of changes

  • ⚪ Bug fix (Change that fixed an issue)
  • ⚪ Breaking change (Change that can cause existing functionality to change)
  • ⚪ Improvement (Change that improves the code. Maybe performance or development improvement)
  • ⚪ Feature (Change that adds new functionality)
  • ⚫ Documentation change (Change that modifies documentation. Maybe typo fixes)

Checklist:

  • ⚪ My code follows the project code style
  • ⚪ I have written test for my code and it has been tested
  • ⚪ All existing tests have been passed
  • ⚪ I have attached a screenshot/video to visualize my change if possible

@Flexo013 Flexo013 added the awaiting review ❇️ Pull request is awaiting a review. label Jan 6, 2020
@ZeroX-DG ZeroX-DG added the help wanted 🆘 Pull request/issue requires extra help from the community. Check these out if you're new! label Jan 6, 2020
@ZeroX-DG
Copy link
Member

ZeroX-DG commented Jan 6, 2020

@xatier can you introduce someone to review this PR?

@xatier
Copy link
Contributor Author

xatier commented Jan 6, 2020

Maybe @rayou? The one who contributed to this doc in the past.

rayou
rayou approved these changes Jan 6, 2020
View reviewed changes
Copy link
Contributor

@rayou rayou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion added, the rest LGTM. 👍

docs/zh_TW/build.md Outdated
https://github.com/BoostIO/Boostnote/pull/2794
</pre>
接著，於底下步驟中把 \<PR> 換成這個號碼 (沒有括號)。
請將上面的 URL 中的 \<PR> 換置成 2794。
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change 請將上面的 to 請將下方 since the URLs are down below. I've updated build.md accordingly.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed!

@xatier
Update build.md
f7fb9dc 
text change per @rayou's suggestion.
ZeroX-DG
ZeroX-DG approved these changes Jan 9, 2020
View reviewed changes
Copy link
Member

@ZeroX-DG ZeroX-DG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably will merge this next week if everyone agree with this translation

@ZeroX-DG ZeroX-DG added approved 👍 Pull request has been approved by sufficient reviewers. and removed awaiting review ❇️ Pull request is awaiting a review. help wanted 🆘 Pull request/issue requires extra help from the community. Check these out if you're new! labels Jan 9, 2020
@xatier
Copy link
Contributor Author

xatier commented Jan 30, 2020

@ZeroX-DG any reason this is not merged yet?

@ZeroX-DG
Copy link
Member

@xatier I don't have the merge permission to merge this PR but this PR is mark as approved and will get merged by @Rokt33r soon. I'll remind him to merge this 😄 sorry for the wait.

@Rokt33r Rokt33r removed the approved 👍 Pull request has been approved by sufficient reviewers. label Feb 3, 2020
@Rokt33r Rokt33r added this to the v0.15.0 milestone Feb 3, 2020
@Rokt33r
Copy link
Member

Rokt33r commented Feb 3, 2020

Thanks for the contribution!

@Rokt33r Rokt33r merged commit 57a5de9 into BoostIO:master Feb 3, 2020
@xatier xatier deleted the patch-1 branch February 4, 2020 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZeroX-DG ZeroX-DG ZeroX-DG approved these changes

@rayou rayou rayou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.15.0
Development

Successfully merging this pull request may close these issues.
5 participants
@xatier @ZeroX-DG @Rokt33r @rayou @Flexo013