Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It would be cool if there was a filter #21

Closed
superbotan opened this issue Jun 9, 2018 · 6 comments
Closed

It would be cool if there was a filter #21

superbotan opened this issue Jun 9, 2018 · 6 comments

Comments

@superbotan
Copy link

for example
for hide pg_temp.... and pg_toast
or for search some function or table

@Borvik
Copy link
Owner

Borvik commented Jun 9, 2018

As far as I know "pg_toast", "pg_temp_1", and "pg_toast_temp_1" should be hidden, but I get the idea. I toyed with the thought of filtering all schemas that start with "pg_", but then if someone goes against conventions and actually names one with a pg_ prefix it wouldn't show.

A solution to put a filter into the configs was put forward - but I rather disliked that solution as it affected all databases and more importantly was something that some may want to change on a regular basis put into the configs.

I have also thought about searching. Ideally I would a search box to the db explorer - but currently I haven't found APIs to support that.

There may be a way to create it as a command for the command palette that could search/filter it... I'll have to investigate this

@gb-jlofton
Copy link

I was thinking the same thing, this is an awesome extension for vs code, but being able to edit/hide certain tables would be really nice! Even if I had to manually go through each table that I wanted to 'hide' that would be excellent as well.

@Borvik
Copy link
Owner

Borvik commented Sep 10, 2018

The hiding/filtering part may not be too difficult - could add a command to the command palette that prompts for the search pattern. The more challenging part would be an indicator and a way to clear that filter. I've got a few ideas on that front that I was given during the webview upgrade.

@davidmach14
Copy link

Your extension was recommended to me by one of PostgreSQL core developers and it looks very promising. Not only because it's very fast. Object filter in the explorer window is an important feature for me because I work with databases that contain a large number of tables. Similar functionality is in DBeaver (see screenshot). Hope you implement this feature soon! :-)
dbeaver-object-filter

@Borvik
Copy link
Owner

Borvik commented Nov 7, 2018

It would be cool. Just looking for the proper way to implement it. When a filter is in place - what gets filtered? Database/schemas/tables/columns/functions - any or all the above? How does DBeaver handle that functionality.

Currently I am unable to add a filter bar like that, however according to MS iteration plan for october (microsoft/vscode#60106) there is "Tree widget performance improvements & filtering support" in the engineering section. Perhaps that filtering support will work for this.

@Borvik
Copy link
Owner

Borvik commented Nov 7, 2019

MSs addition of tree filter works for this db explorer. With the nodes expanded, if you type with the explorer focused it should filter automatically.

@Borvik Borvik closed this as completed Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants