Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Edit] React: Props - Update from class to function based components #4788

Open
2 of 3 tasks
roryyeung opened this issue Jun 19, 2024 · 13 comments · May be fixed by #5911
Open
2 of 3 tasks

[Edit] React: Props - Update from class to function based components #4788

roryyeung opened this issue Jun 19, 2024 · 13 comments · May be fixed by #5911
Assignees
Labels
claimed Issue is claimed and closed to further assignment enhancement New feature or request react React entries

Comments

@roryyeung
Copy link

roryyeung commented Jun 19, 2024

Type of Edit (select all that apply)

Add new content (definitions, codeblocks, etc.)

Description (optional)

Page still uses class based components:

https://www.codecademy.com/resources/docs/react/props

The course currently uses function based components.

Should we update this?

Code of Conduct

  • By submitting this issue, I agree to follow Codecademy Doc's Code of Conduct.

For Maintainers

  • Labels added
  • Issue is assigned
@roryyeung roryyeung added enhancement New feature or request typo Fixing a typo labels Jun 19, 2024
@Linchihj
Copy link
Contributor

Hi @roryyeung,
I can help fix any typos in the document. Would you like me to help you with this task?

@Linchihj
Copy link
Contributor

Sorry, please don't assign this task to me. I realized this is out of my scope.

@ishg-153
Copy link
Contributor

@roryyeung Please remember for future contributions that you must ask to be assigned to one of the available issues and once assigned you can create a PR for that issue. This stands true even when you suggest the new issue, because we need to evaluate whether this change needs to be made to docs.

@ishg-153 ishg-153 added react React entries claimed Issue is claimed and closed to further assignment and removed typo Fixing a typo labels Jun 21, 2024
@ishg-153
Copy link
Contributor

@roryyeung You're Assigned!🎉

@ishg-153 ishg-153 linked a pull request Jun 21, 2024 that will close this issue
@Sriparno08
Copy link
Collaborator

Hey @roryyeung, are you still working on this issue?

Note: If there's no response from your side in a week, you will be unassigned unfortunately.

@Sriparno08
Copy link
Collaborator

Unassigning the author due to inactivity.

@Sriparno08 Sriparno08 removed the claimed Issue is claimed and closed to further assignment label Nov 29, 2024
@mamtawardhani mamtawardhani self-assigned this Dec 20, 2024
@mamtawardhani mamtawardhani added the claimed Issue is claimed and closed to further assignment label Dec 20, 2024
@thedarkking01
Copy link

Hi @roryyeung,
Could you please assign this issue to me? 😊

@ShravanTalabhaktula
Copy link

Hi there, seems like no one is working on this topic. Can you guys remove the claimed label and reassign to me? I'm interested. Thanks.

@mamtawardhani
Copy link
Collaborator

Apologies for the delay, @thedarkking01 @ShravanTalabhaktula would one you like to take up this issue?

@mamtawardhani mamtawardhani removed their assignment Jan 2, 2025
@mamtawardhani mamtawardhani removed the claimed Issue is claimed and closed to further assignment label Jan 2, 2025
@thedarkking01
Copy link

thedarkking01 commented Jan 2, 2025

Thank you for the response, @mamtawardhani! I'd be happy to take up this issue and start working on it 😊

@mamtawardhani
Copy link
Collaborator

Hey @thedarkking01 You’re assigned 🎉 In addition to the documents linked in the description, please also look at the Contribution Guide. After creating a PR, the maintainer(s) (with the collaborator label) will add comments/suggestions to address any revisions before approval.

Is this your first contribution to Codecademy Docs? If so, we’re curious to know how you found out about contributing to Docs.

@mamtawardhani mamtawardhani added the claimed Issue is claimed and closed to further assignment label Jan 2, 2025
@thedarkking01
Copy link

thedarkking01 commented Jan 2, 2025

Thanks @mamtawardhani for assigning issue
Yeah it is my first contribution to Codecademy Docs and i find this contribution by exploring the github
Let me know if there are any specific details or guidelines I should keep in mind.

@thedarkking01
Copy link

thedarkking01 commented Jan 2, 2025

Hii @mamtawardhani 😊
I have raised PR #5911 kindly please accept my PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
claimed Issue is claimed and closed to further assignment enhancement New feature or request react React entries
Projects
None yet
7 participants