Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for google ocr #662

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

BushrHaddad
Copy link

@BushrHaddad BushrHaddad commented Dec 30, 2024

Add support for google OCR.

This PR introduces support for Google OCR using the Google Vision API. It includes the addition of new OCR options, GoogleOcrOptions, and a corresponding OCR model GoogleOcrModel.

Issue resolved by this Pull Request:
Resolves #661

Checklist:

  • Documentation has been updated, if necessary.
  • Examples have been added, if necessary.
  • Tests have been added, if necessary.

Copy link

mergify bot commented Dec 30, 2024

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

🟢 Enforce conventional commit

Wonderful, this rule succeeded.

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert)(?:\(.+\))?(!)?:

@dolfim-ibm
Copy link
Contributor

@BushrHaddad Thanks for this new feature. We are currently preparing some design specs on how we could allow models which perform remote communication. We will keep you posted in this thread.

Meanwhile, we would ask you to update your PR with the latest changes in the main branch and DCO failure.

Commit sha: 03fd79a, Author: Mr.Haddad, Committer: Mr.Haddad; Expected "Mr.Haddad [email protected]", but got "Bushr Haddad [email protected]".

This could be addressed with git rebase HEAD~1 --signoff.

@BushrHaddad BushrHaddad force-pushed the feat-support-google-ocr branch from 03fd79a to aae5167 Compare January 8, 2025 08:33
@BushrHaddad BushrHaddad closed this Jan 8, 2025
@BushrHaddad BushrHaddad force-pushed the feat-support-google-ocr branch from e571e31 to ead396a Compare January 8, 2025 09:08
Add support for google OCR.

Signed-off-by: Mr.Haddad <[email protected]>
@BushrHaddad BushrHaddad reopened this Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Support for Google OCR Integration in Docling
2 participants