-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some Panics cause segfaults in jemalloc when called from flate2 #14
Comments
Is this what #36 is supposed to fix? |
I don't know if that was background for it, but it may be related yea. It's something that needs to be sorted in either case. Ideally we woulldn't go through the C Api for flate2 (#16). Going through a C API will always require unsafe. The project got a bit stalled, but I at least want to look into this again. Would be nice to have some more eyes and help on this though :) |
I couldn't reproduce this with the current code, so this may have been fixed as of now, but I'll do some more testing before closing. |
Closing this for now since the C api is no longer used and I haven't been able to reproduce this. |
Forgot to actually click close.. |
Ideally we should never panic of course, but there could still be bugs, and if there are, it shouldn't end up in a segfault.
See this
I've tried with removing no_mangle and extern_c from mz_inflate, so that doesn't seem to be the issue.
The text was updated successfully, but these errors were encountered: