Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker image with PostgreSQL #75

Open
HiromuHota opened this issue May 12, 2020 · 0 comments · May be fixed by #76
Open

Docker image with PostgreSQL #75

HiromuHota opened this issue May 12, 2020 · 0 comments · May be fixed by #76
Assignees

Comments

@HiromuHota
Copy link
Contributor

Is your feature request related to a problem? Please describe.

Currently, if you run docker-compose up, two Docker containers are spawned: one for Fonduer and another for PostgreSQL.
This was easy for developer perspective, but it may not necessarily good for users.
For example, you want to deploy this tutorials on JupyterHub or Kubeflow, but it is not possible because they can only deploy a single Docker image. Maybe there is a way but it is not straight-forward.

Describe the solution you'd like

Install Fonduer and PostgreSQL in a single Docker image.

Describe alternatives you've considered

In the longer-term, we may be able to remove the PostgreSQL dependency from Fonduer, but it takes time and much more work.

Additional context

When I first created a Docker image for this tutorials, I made this architectural decision (ie two containers).
This is because it was a lot easier than installing both in a single image. Also partly because this architecture looked against the best practice:

It is generally recommended that you separate areas of concern by using one service per container.

https://docs.docker.com/config/containers/multi-service_container/

Now I see it the other way around. Postgres is tightly coupled by Fonduer, in fact Fonduer does not work without it. From user perspective, they provide a single service.

@senwu senwu assigned senwu and HiromuHota and unassigned senwu May 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants