Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Self signed certificates don't lead to error but just to blank page #1615

Open
Utopiah opened this issue Nov 3, 2024 · 2 comments · May be fixed by #1669
Open

Self signed certificates don't lead to error but just to blank page #1615

Utopiah opened this issue Nov 3, 2024 · 2 comments · May be fixed by #1669
Labels
bug Something isn't working chromium Issues related to the new Chromium backend

Comments

@Utopiah
Copy link

Utopiah commented Nov 3, 2024

Configuration

Wolvic version: Wolvic Chromium 1.1
Wolvic build ID: 183021044

Hardware: Quest 3

Steps to Reproduce

  1. Open a self-signed HTTPS website or a website with an expired certificate

Current Behavior

Get a blank page, no content, no error or warning

Expected Behavior

Expect a warning or error message, ideally allowing to accept and go through anyway

Possible Solution

Follow what the Quest or Chrome or Firefox do, namely provide the option to accept temporarily the certificate after showing the problem

Context

Developing content often means self-hosting on LAN urls, e.g. https://192.168.0.123:3000/index.html and providing HTTPS is required to get WebXR.

Error Logs and Stack Traces
@svillar svillar added bug Something isn't working chromium Issues related to the new Chromium backend labels Nov 6, 2024
@haanhvu
Copy link
Collaborator

haanhvu commented Dec 13, 2024 •
edited
Loading

I'm debugging this. One thing I noticed is that there's an onLoadError() that returns the result of error page:

wolvic/app/src/common/shared/com/igalia/wolvic/browser/engine/Session.java

Lines 1240 to 1245 in 71ec70e

@Override
public WResult<String> onLoadError(@NonNull WSession session, @Nullable String uri, @NonNull WWebRequestError error) {
Log.d(LOGTAG, "Session onLoadError: " + uri);
return WResult.fromValue(InternalPages.createErrorPageDataURI(mContext, uri, error.code()));
}

However, the returned result of this function is not used in the Chromium implementation:

wolvic/app/src/common/chromium/com/igalia/wolvic/browser/api/impl/TabWebContentsObserver.java

Line 119 in 71ec70e

navigationDelegate.onLoadError(mSession, failingUrl.getSpec(), new WWebRequestError() {

Seems like it should be used somewhere to show the error page?

@svillar
Copy link
Member

svillar commented Dec 13, 2024

I'm debugging this. One thing I noticed is that there's an onLoadError() that returns the result of error page:

wolvic/app/src/common/shared/com/igalia/wolvic/browser/engine/Session.java

Lines 1240 to 1245 in 71ec70e

@Override
public WResult<String> onLoadError(@NonNull WSession session, @Nullable String uri, @NonNull WWebRequestError error) {
Log.d(LOGTAG, "Session onLoadError: " + uri);
return WResult.fromValue(InternalPages.createErrorPageDataURI(mContext, uri, error.code()));
}

However, the returned result of this function is not used in the Chromium implementation:

wolvic/app/src/common/chromium/com/igalia/wolvic/browser/api/impl/TabWebContentsObserver.java

Line 119 in 71ec70e

navigationDelegate.onLoadError(mSession, failingUrl.getSpec(), new WWebRequestError() {

Seems like it should be used somewhere to show the error page?

Yes, I think we could use the same error page as with gecko

haanhvu added a commit to haanhvu/wolvic that referenced this issue Jan 7, 2025
@haanhvu
Chromium: Show error pages when errors happen
84913b6 
Currently when errors happen when loading a website, Wolvic with Chromium backend just returns a blank page. This fix allows Wolvic with Chromium backend to return an error page customized to each error.

Fix Igalia#1615
@haanhvu haanhvu linked a pull request Jan 7, 2025 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working chromium Issues related to the new Chromium backend
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Chromium: Show error pages when errors happen haanhvu/wolvic
3 participants
@Utopiah @svillar @haanhvu