Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encourage NumPy dependent projects to upgrade to version >=2.5.0 #20527

Open
adosar opened this issue Jan 5, 2025 · 0 comments
Open

Encourage NumPy dependent projects to upgrade to version >=2.5.0 #20527

adosar opened this issue Jan 5, 2025 · 0 comments
Labels
docs Documentation related needs triage Waiting to be triaged by maintainers

Comments

@adosar
Copy link
Contributor

adosar commented Jan 5, 2025

📚 Documentation

As mentioned in the Changelog, version 2.5.0 introduces a robust scheme for seeding NumPy dependent dataloader workers.

As described in the related PR #20369, until this version Lightning was not handling correctly the seeding for NumPy, meaning that all projects using NumPy for controlling randomness (e.g. random transformations for augmentation) are affected (see here and also here).

Since NumPy is commonly used for augmentations in deep learning projects (see also the example from PyTorch docs) and proper control of seeding/randomness is essential for any project, I think it would be beneficial to add a note/warning in the docs to use version 2.5.0 or higher if randomness depends on NumPy.

cc @Borda

@adosar adosar added docs Documentation related needs triage Waiting to be triaged by maintainers labels Jan 5, 2025
@adosar adosar changed the title Encourage users to upgrade to version >=2.5.0 Encourage NumPy dependent projects to upgrade to version >=2.5.0 Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation related needs triage Waiting to be triaged by maintainers
Projects
None yet
Development

No branches or pull requests

1 participant