Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unecessary trailling spaces #6

Closed
badouralix opened this issue Nov 27, 2017 · 4 comments
Closed

Unecessary trailling spaces #6

badouralix opened this issue Nov 27, 2017 · 4 comments

Comments

@badouralix
Copy link

autoDocstring adds trailling spaces on blank line 3 of the following example, and more generally on blank lines between sections.

1  def function():
2     """[summary]
3     
4     [description]
5     """
6     pass

They should be removed in order to be compliant with PEP8.

@NilsJPWerner
Copy link
Owner

You are correct, I didn't notice it because I have set vscode to automatically remove trailing spaces. Will fix asap.

@badouralix
Copy link
Author

I'm pretty sure this is an easy fix, that I could do myself and then submit an PR. Unfortunately, I couldn't properly set up VSCode to dev plugins... Even the hello world example build fails on my computer... ( node v8.7.0, npm 5.5.1 and vscode 1.18.1 ). How is your environment set up ?

@NilsJPWerner
Copy link
Owner

Hi, sorry for the deley. I took a look at this and the change will be a little more involved than I thought since the indentation is created by the insertSnippet vscode editor function which isn't intelligent enough to deal with trailing spaces: microsoft/vscode#20112 I will need to build my own indentation method when generating the snippet.

As for the dev environment. I have node v8.9.1, npm 5.5.1 and vscode 1.19.0 with nothing else special. What is the failure message? It may be better to debug that issue at the official vscode repo.

@NilsJPWerner
Copy link
Owner

I have opened an issue on the vscode github page. I will revisit this when the issue is fixed. For now enabling the files.trimTrailingWhitespace or using the trailing-spaces extension should take care of the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants