Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect sounds.json entry for bass drum in extra notes resource pack #479

Closed
Bentroen opened this issue Sep 25, 2024 · 0 comments
Closed

Incorrect sounds.json entry for bass drum in extra notes resource pack #479

Bentroen opened this issue Sep 25, 2024 · 0 comments
Labels
C: Bug Something isn't working S: Resolved in next release This bugfix or suggestion has been applied to the code
Milestone
v3.11

Comments

@Bentroen
Copy link
Member

Bentroen commented Sep 25, 2024 •
edited
Loading

The sounds.json in the extra notes resource pack points to sound files named bd_-1 and bd_1, but the files are actually called basedrum_-1 and basedrum_1 in the pack. This causes bass drum sounds lower or higher than the two-octave range to be missing when played through a data pack.

image

image
@Bentroen Bentroen added the C: Bug Something isn't working label Sep 25, 2024
@Bentroen Bentroen added the S: Resolved in next release This bugfix or suggestion has been applied to the code label Dec 1, 2024
@Bentroen Bentroen added this to the v3.11 milestone Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C: Bug Something isn't working S: Resolved in next release This bugfix or suggestion has been applied to the code
Projects
None yet
Milestone
v3.11
Development

No branches or pull requests
1 participant
@Bentroen