Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Registered button in Livechat room is not visible #679

Open
cuonghuunguyen opened this issue Nov 22, 2023 · 1 comment
Open

Registered button in Livechat room is not visible #679

cuonghuunguyen opened this issue Nov 22, 2023 · 1 comment

Comments

@cuonghuunguyen
Copy link
Contributor

Precondition

  • Don't enable any extra Room Action for the livechat (like canned response)

Reproduce

  • Register a button to the Livechat Room action bar
configurationExtend.ui.registerButton({
			actionId: "test-button",
			labelI18n: "Test Button",
			context: UIActionButtonContext.ROOM_ACTION,
			when: {
				roomTypes: [RoomTypeFilter.LIVE_CHAT]
			}
		});

It will appear invisible like this:
image

The button is still clickable but the user cannot see it.

Due to the guidelines here: https://developer.rocket.chat/apps-engine/extend-app-capabilities/apps-engine-user-interface/apps-engine-ui-guidelines and the code here https://github.com/RocketChat/Rocket.Chat/blob/develop/apps/meteor/client/views/room/providers/hooks/useAppsRoomActions.ts#L26. We cannot specify an icon for the register button.

Do you have any recommendation or should we allow adding icon for the registered button to solve this case?

@Sumitwarrior7
Copy link

i am new to this Apps-engine project, and i want to contribute to this project as a newbie.
As i have not found any community channel specific to this project, so if it is there please share it with me
And also please guide me in how can i contribute here

i want to work on this issue, so please assign it to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants