Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: re-disable in buffers where b:completion is false #577

Closed
wants to merge 1 commit into from

Conversation

b0o
Copy link
Contributor

@b0o b0o commented Dec 15, 2024

Fixes logic from #574 for when b:completion is false. Also updated example configuration in README.md.

@Saghen
Copy link
Owner

Saghen commented Dec 15, 2024

I ought to have looked more carefully, sorry about that. Would this be functionally equivalent to the original code? return vim.bo.buftype ~= 'prompt' and vim.b.completion ~= false

@Saghen Saghen closed this in cfd1b7f Dec 15, 2024
@Saghen
Copy link
Owner

Saghen commented Dec 15, 2024

Reverted the commit on main, thanks!

@b0o
Copy link
Contributor Author

b0o commented Dec 15, 2024

Ah, you're right. I'm not sure why @soifou was experiencing the issue, as the original logic does seem correct (tested in a prompt buffer and a b:completion = false buffer).

@soifou
Copy link
Contributor

soifou commented Dec 15, 2024

I'm sorry guys, I mixed up 'nofile' and 'prompt' buffers... I was suprised that editing a DressingInput trigger the completion list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants