-
-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sol.u should be Array{T, 2} #1057
Comments
No it is not. It's a
You can always just do
No, it's the opposite. With adaptivity, you'd have to guess the matrix size. If you guess wrong, you'd have to re-allocate the matrix and copy pieces over. Copying vectors is straightforward and can even be done async to mask it. It ends up being a lot faster to push to. There's many experiments in the repo on this. It's also not possible. You're only thinking of |
Ah, I see. Completely reasonable, sorry for the waste of time. I'll close this. |
Is your feature request related to a problem? Please describe.
sol.u
is a time series (vector in time), and there are multiple ways in scientific libraries to represent them. Currently,sol.u
isVector{Float64}
for 1D problems, andVector{Vector{T}}
for multi-D problems. This frustrates me for two reasons:AbstractArrays
in the formarr[:, time]
without handling the "special" 1D case.sol.u
andsol
array interface should be the same for everything.Describe the solution you’d like
sol.u
is anArray{T, 2}
, andsol
has anArray{T,2}
interface. This would solve my two problems entirely.Additional context
I know this would require a massive refactor and much work. If there is interest, I can collaborate. If you close this request, please at least provide information as to why
Vector{Vector{T}}
was chosen.The text was updated successfully, but these errors were encountered: