Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

<!-- Thank you for submitting a pull request. Please read our pull request guidelines before #1

Open
3 tasks
Thagoldenchild420 opened this issue Jul 30, 2023 · 0 comments
Open
3 tasks

<!-- Thank you for submitting a pull request. Please read our pull request guidelines before #1

Thagoldenchild420 opened this issue Jul 30, 2023 · 0 comments
Assignees
@Thagoldenchild420
Labels
bug Something isn't working documentation Improvements or additions to documentation duplicate This issue or pull request already exists enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed invalid This doesn't seem right question Further information is requested wontfix This will not be worked on

Comments

@Thagoldenchild420
Copy link
Owner

Include column numbers in the GitHub location URLs, in the format LstartlineCstartcolumnLendlineCendcolumn.

Warning: It looks like this is not fully supported by the GitHub web interface, neither for the old code view nor the new code view, see https://github.com/orgs/community/discussions/48301#discussioncomment-5831155. Might be good to clarify this with your colleagues.
No worries if you decide to reject this pull request.

Also, I am not very familiar with this project yet, so please let me know if overlooked something or if there is something else I should change. Any feedback is appreciated!

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

Originally posted by @Marcono1234 in github/vscode-codeql#2406
@Thagoldenchild420 Thagoldenchild420 added bug Something isn't working documentation Improvements or additions to documentation duplicate This issue or pull request already exists enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers invalid This doesn't seem right question Further information is requested wontfix This will not be worked on labels Jul 30, 2023
@Thagoldenchild420 Thagoldenchild420 self-assigned this Jul 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Thagoldenchild420 Thagoldenchild420

Labels
bug Something isn't working documentation Improvements or additions to documentation duplicate This issue or pull request already exists enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed invalid This doesn't seem right question Further information is requested wontfix This will not be worked on
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Thagoldenchild420