Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wihout entering nickname, create room button must be disabled #116

Open
mevlutcantuna opened this issue Feb 7, 2024 · 4 comments
Open

Wihout entering nickname, create room button must be disabled #116

mevlutcantuna opened this issue Feb 7, 2024 · 4 comments
Labels
app: client Client project folder good first issue Good for newcomers type: feature New feature or request

Comments

@mevlutcantuna
Copy link
Contributor

If a user doesn't enter a nickname and clicks the create room button, it waits forever and the user must refresh the page.
Instead, the create room button can be disabled.

Ekran Resmi 2024-02-07 16 05 10
@mevlutcantuna
Copy link
Contributor Author

Hi @armagandalkiran @mertcanaltin,

If there is a design for the disabled state of a button component, I would like to implement it and if there is not, I can give it opacity.It will be showed like below.

Ekran Resmi 2024-02-07 16 11 57

@armagandalkiran
Copy link
Collaborator

Thank you for your attention. @aahmetcakir can you take a look kardo ?

@armagandalkiran armagandalkiran added type: feature New feature or request good first issue Good for newcomers app: client Client project folder labels Feb 7, 2024
@aahmetcakir
Copy link
Contributor

we can use https://www.figma.com/file/3Rvo2R5AWAse3O09KtuhZT/GurubuV2?type=design&node-id=741-6773&mode=design&t=8k47OFWrDFRpTIi3-0 this design karo

@mevlutcantuna
Copy link
Contributor Author

@aahmetcakir @armagandalkiran this pr fixes this issue. #145

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
app: client Client project folder good first issue Good for newcomers type: feature New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@aahmetcakir @mevlutcantuna @armagandalkiran