Pulling {latest} via WebHook

[sontags]

# caddy -version
Caddy 0.11.1 (non-commercial use only)

Considering the following Caddyfile:

http://www.example.com {
    root /web/www.example.com/public
    git https://github.com/example/example.com {
        hook     /path TOKEN
        branch   {latest}
        path     ..
        then     /hugo --destination=/web/www.example.com/public --cleanDestinationDir
    }
}

http://beta.example.com {
    root /web/beta.example.com/public
    git https://github.com/example/example.com {
        hook     /path TOKEN
        branch   master
        path     ..
        then     /hugo --destination=/web/beta.example.com/public --cleanDestinationDir
    }
}

The expected behaviour is:

• On a commit/push to the repo beta.example.com will be updated.
• On a commit/push to the repo www.example.com will NOT be updated. (Caddy log: 2018/12/06 12:00:55 github webhook ignored. Error: found different branch master).
• On a tag/push --tags to the repo beta.example.com will be updated with no effect
• On a tag/push --tags to the repo www.example.com will be updated to latest version.

Effective behaviour is:

• commit/push works as expected.
• tag/push --tags gives the following error for BOTH instances (www/beta):
  2018/12/06 12:02:44 github webhook ignored. Error: found different branch v1.0.4 where v1.0.4 is the latest tag.

A restart of Caddy results in the expected behaviour.

Is this a bug or is my understanding of the plugin wrong?

[sontags]

Probably related to #50

[sontags]

Any opinions on this? If this is a bug I am willing to dig into this. But I have no urge to write a PR if the current behavior intentional so it would be helpful to get some feedback.

[abiosoft]

That is a bug. It appears {latest} is deduced once at startup and kept using the static value afterwards.

[sontags]

Thanks, I'll have a try preparing a pr in the next few days!