Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: docker trying to filter out missing docs package #978

Merged
merged 2 commits into from
Dec 10, 2024

Conversation

odilitime
Copy link
Collaborator

Risks

Low

Background

What does this PR do?

Fixes pnpm docker by adding a custom action for build for docker block-docker

Changed the Dockerfile to use this new action, which gets around the docs package not found when filtering.

This was the error

101.0 
101.0 > eliza@ build /app
101.0 > turbo run build --filter=!eliza-docs
101.0 
101.3 
101.3 Attention:
101.3 Turborepo now collects completely anonymous telemetry regarding usage.
101.3 This information is used to shape the Turborepo roadmap and prioritize features.
101.3 You can learn more, including how to opt-out if you'd not like to participate in this anonymous program, by visiting the following URL:
101.3 https://turbo.build/repo/docs/telemetry
101.3 
101.3 turbo 2.3.3
101.3 
101.8   x No package found with name 'eliza-docs' in workspace
101.8 
101.8  ELIFECYCLE  Command failed with exit code 1.
------

What kind of change is this?

Bug fixes (non-breaking change which fixes an issue)

Why are we doing this? Any context or related work?

Neo reported an issue, confirmed issue on my server. Came up with this workaround.

Documentation changes needed?

My changes do not require a change to the project documentation.

@odilitime odilitime changed the title Fix: docker trying to filter out missing docs package fix: docker trying to filter out missing docs package Dec 10, 2024
@HashWarlock
Copy link
Collaborator

Nice, I think the reason the error gets thrown is due to the docs not being included in the setup before the docker build command is executed in the docker file. This was to reduce the docker image size. I think this is a good workaround.

Copy link
Member

@shakkernerd shakkernerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good.

@shakkernerd shakkernerd merged commit e8dab54 into elizaOS:main Dec 10, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants