feat: new core plugins #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds new core plugins for Help, Webserver, and Health and supporting code to make it possible to load them. I had to overload some of the Err backend methods and monkey patch some methods in the PluginManager. Eventually, I'd like to upstream these changes and this will no longer be needed
This allows setting a new flag in the Core section of the .plug file to indicate a plugin is a backend. These backend plugins are then skipped when loaded by _load_plugins_generic This code could eventually be upstreamed into Errbot to allow it to handle multiple plugins per module easier
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds new core plugins for Help, Webserver, and Health and supporting code to make it possible to load them.
I had to overload some of the Err backend methods and monkey patch some methods in the PluginManager to allow loading multiple plugins from a single module and to exclude backend .plug files from _load_plugins_generic.
Eventually, I'd like to upstream these changes, and some of this code will no longer be needed.