Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(github_nulls): Better handling of Nulls in GitHub API #39

Merged
merged 2 commits into from
May 25, 2023

Conversation

actuarysailor
Copy link
Contributor

@actuarysailor actuarysailor commented May 24, 2023

This now converts nulls returned from GitHub API into appropriate value, such as an empty array etc., to make fields comparable even if missing. Previously there were cases where the nulls from the GitHub API would cause an error when trying to perform the comparisons.

Fixes #31

shiro added 2 commits May 23, 2023 19:43
Corrects issue where GitHub repo currently contains no elements, but config file does
@actuarysailor actuarysailor marked this pull request as ready for review May 24, 2023 01:24
@andrewthetechie andrewthetechie merged commit 6744d11 into andrewthetechie:main May 25, 2023
@actuarysailor actuarysailor deleted the bug_31 branch May 26, 2023 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: Repository JSON null but Config YAML not
2 participants