Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing tonic GRPC_STATUS with tonic 0.12.1 #6515

Closed
cisaacson opened this issue Oct 6, 2024 · 6 comments · Fixed by #6517
Closed

Missing tonic GRPC_STATUS with tonic 0.12.1 #6515

cisaacson opened this issue Oct 6, 2024 · 6 comments · Fixed by #6517
Labels
arrow Changes to the arrow crate arrow-flight Changes to the arrow-flight crate bug enhancement Any new improvement worthy of a entry in the changelog good first issue Good for newcomers help wanted

Comments

@cisaacson
Copy link
Contributor

The current master does not compile, it is missing this status:

no associated item named `GRPC_STATUS` found for struct `Status` in the current scope
    --> arrow-flight/src/arrow.flight.protocol.rs:1578:48

Changing the version of prost in arrow-flight/Cargo.toml to the following fixes this:

tonic = { version = "0.12.3", default-features = false, features = ["transport", "codegen", "prost"] }

The current version of tonic is "0.12.1"

@cisaacson cisaacson added the bug label Oct 6, 2024
@tustvold
Copy link
Contributor

tustvold commented Oct 6, 2024

I suspect your local checkout has a lockfile that is pinning the version to the old version, we should uodate the dependency though if we're depending on something added in a newer patch release

@tustvold tustvold added good first issue Good for newcomers enhancement Any new improvement worthy of a entry in the changelog help wanted and removed bug labels Oct 6, 2024
@cisaacson
Copy link
Contributor Author

@tustvold I did update to the latest code and the issue still exists. This patch allows it to compile for me now. Let me know what you think.

@tustvold
Copy link
Contributor

tustvold commented Oct 6, 2024

I did update to the latest code and the issue still exists

The lockfile is in the .gitignore, you need to either delete Cargo.lock or run cargo update. That being said there is no harm in us updating the version in the Cargo.toml to force it to pick the newest version.

@alamb
Copy link
Contributor

alamb commented Oct 7, 2024

For anyone else that hits this, a workaround is likely to do cargo update for your project, as @tustvold says

@alamb alamb added the arrow Changes to the arrow crate label Oct 20, 2024
@alamb
Copy link
Contributor

alamb commented Oct 20, 2024

label_issue.py automatically added labels {'arrow'} from #6517

@alamb alamb added the arrow-flight Changes to the arrow-flight crate label Oct 20, 2024
@alamb
Copy link
Contributor

alamb commented Oct 20, 2024

label_issue.py automatically added labels {'arrow-flight'} from #6517

@alamb alamb added the bug label Oct 20, 2024
@alamb alamb changed the title Missing tonic GRPC_STATUS Missing tonic GRPC_STATUS with tonic 0.12.1 Oct 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate arrow-flight Changes to the arrow-flight crate bug enhancement Any new improvement worthy of a entry in the changelog good first issue Good for newcomers help wanted
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants