Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for ECSCredentials #33

Closed
Larisho opened this issue May 5, 2022 · 4 comments · Fixed by #34
Closed

Support for ECSCredentials #33

Larisho opened this issue May 5, 2022 · 4 comments · Fixed by #34

Comments

@Larisho
Copy link

Larisho commented May 5, 2022

We're trying to use this package in a deno app deployed via ECS and we're getting credential errors when trying to connect to dynamodb. On inspection of lib/client/credentials.ts, I noticed that ECSCredential handling is commented out/not included.

// () => new ECSCredentials(),

Adding support for this would be really helpful.

@danopia
Copy link
Member

danopia commented May 5, 2022

Hello, thank you for the request! I haven't had an ECS environment handy, which meant I couldn't have verified the code if I had written it already.

I'll put together an implementation and respond here so you could ideally verify it in your environment. That would help me be confident about merging it into main and shipping a new minor version.

@Larisho
Copy link
Author

Larisho commented May 5, 2022

That would be great. Really appreciate it

@danopia
Copy link
Member

danopia commented May 5, 2022

Hi again, not sure how convenient it is for you to verify a raw version from an open PR. I made a small get-ecs-identity.ts example which can be run directly:

deno run --no-prompt --allow-env --allow-net https://gist.githubusercontent.com/danopia/36788750e91fb721ad4d61bc33a61e2c/raw/a4a3adba8ad512055bdda05b2e9fd48190e05e95/get-ecs-identity.ts

I did some sanity checks locally but I haven't seen a full example response from ECS so there's a little bit of guessing. Let me know if you aren't able to verify and I could try briefly running ECS in my own account instead.

@Larisho
Copy link
Author

Larisho commented May 5, 2022

I've verified that it works on our ECS. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants