-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for ECSCredentials #33
Comments
Hello, thank you for the request! I haven't had an ECS environment handy, which meant I couldn't have verified the code if I had written it already. I'll put together an implementation and respond here so you could ideally verify it in your environment. That would help me be confident about merging it into main and shipping a new minor version. |
That would be great. Really appreciate it |
Hi again, not sure how convenient it is for you to verify a raw version from an open PR. I made a small
I did some sanity checks locally but I haven't seen a full example response from ECS so there's a little bit of guessing. Let me know if you aren't able to verify and I could try briefly running ECS in my own account instead. |
I've verified that it works on our ECS. Thanks! |
We're trying to use this package in a deno app deployed via ECS and we're getting credential errors when trying to connect to dynamodb. On inspection of
lib/client/credentials.ts
, I noticed that ECSCredential handling is commented out/not included.deno-aws_api/lib/client/credentials.ts
Line 55 in a383db0
Adding support for this would be really helpful.
The text was updated successfully, but these errors were encountered: