Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

electron: -max-http-header-size=1048576 is not allowed in NODE_OPTIONS #8601

Closed
ghermet opened this issue Sep 17, 2020 · 8 comments
Closed

Comments

@ghermet
Copy link

ghermet commented Sep 17, 2020

Current behavior:

It seems like one of the NODE_OPTIONS attributes is wrongly set using -max-http-header-size instead of --max-http-header-size in electron

Screenshot 2020-09-17 at 14 03 10

Desired behavior:

When running yarn cypress run in the terminal, the tests should run.

Test code to reproduce

// run from where the cypress dependency is located (package.json)
yarn install
yarn cypress run

Versions

Cypress: 5.2.0
OS: macOS Catalina 10.15.6
@FDiskas
Copy link

FDiskas commented Sep 17, 2020

Try run this command not in vscode integrated terminal

@bahmutov
Copy link
Contributor

Yes, try using terminal outside of the editor

@ghiscoding
Copy link

Oh wow I've been struggling to find a solution for this on my work laptop and that was it... thanks guys.

However doesn't anyone have a solution to get it working in VSCode or we're stuck having to always start it from outside?
I would rather be able to run it through VSCode, it's much quicker and I have an npm script to open it from there

@FDiskas
Copy link

FDiskas commented Sep 18, 2020

Are you using beta vscode version?
For some time it was working in my vscode but after some uodates it's stoped.

Or - wait a sec. My last changes was running tests with --browser electron
Instead of chrome. Is it related?

@ghiscoding
Copy link

ghiscoding commented Sep 18, 2020

@FDiskas
Thanks you made me think I should try in stable VSCode and it actually works on that version, I kept trying on VSCode insiders and it doesn't work there but I'm assuming it's because the MS team is trying the latest Electron version in VSCode insiders... so all that to say, VSCode Stable is OK but VSCode Insiders (it stopped working not that long ago) is not and it's because of the new Electron version from VSCode itself.

So that helps in identifying the source, thanks for that

I added a comment in their issue to upgrade to Electron 9, let's see what their reply will be...

@ghermet
Copy link
Author

ghermet commented Sep 22, 2020

Are you using beta vscode version?
For some time it was working in my vscode but after some uodates it's stoped.

Or - wait a sec. My last changes was running tests with --browser electron
Instead of chrome. Is it related?

Yes I'm using VSCode Insider

@ghiscoding
Copy link

ghiscoding commented Sep 22, 2020

@ghermet
is that a confirmation that this bug is just with VSCode insiders not stable?
On my side, I tried with 3 different computers and they all have the problem only with the VSCode insider.

It seems that no one replied to my comment on their Electron 9 upgrade, but I'm quite sure it's related and that is only on the insiders for now.

@dtinth
Copy link

dtinth commented Jan 25, 2021

However doesn't anyone have a solution to get it working in VSCode or we're stuck having to always start it from outside?
I would rather be able to run it through VSCode, it's much quicker and I have an npm script to open it from there

Workaround for PowerShell

$env:NODE_OPTIONS = ''
yarn cypress open

Workaround for UNIX-like

env NODE_OPTIONS= yarn cypress open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants