Adds CLI hooks (IDs) to certain elements #592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically deployed with Now. |
mixn
changed the title
|
@mixn thanks for this and sorry about breaking your tool 😬 I updated the id's to have a more consistent naming, and release. Hope that works! |
|
@mfix22 No worries at all and thank you for the quick merge and deploy! 👏 Patching the CLI as we speak. Thanks again! 👍 |
|
@mfix22 All the IDs except for
|
|
@mixn apologies for this, I am pushing the updates now. Do you have time to add Cypress integration tests that test for the existence of these id's to our existing test suite? |
|
@mixn the release was just pushed — hopefully everything is fixed 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi guys. :)
v3.6.0introduced some breaking changes to the CLI I’m maintaining and trying to keep in sync (feature-wise).I texted @mfix22 on Twitter about maybe adding some (non-changing) hooks for the CLI, so this doesn’t happen in the future any more. :)
I hereby added four
ids for all the things the CLI accesses. Let me know if any changes are needed (maybe namespacing?)… :)Thanks for being so responsive about this, hope to patch the CLI as soon as this is merged and deployed. :)
🙏