Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Typescript bindings do not include event models #2781

Open
rsodre opened this issue Dec 6, 2024 · 2 comments
Open

[BUG] Typescript bindings do not include event models #2781

rsodre opened this issue Dec 6, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@rsodre
Copy link

rsodre commented Dec 6, 2024

Describe the bug

Event models created with #[dojo::event] are not being included in the typescript bindings schema.

To Reproduce

Build dojo-starter, as it has the event model Moved...

$ git clone https://github.com/dojoengine/dojo-starter
Cloning into 'dojo-starter'...
$ cd dojo-starter 
$ sozo build --typescript
$ grep Moved bindings/typescript/models.gen.ts 
$ 

Expected behavior

To be able to create queries for event models from Torii using the JS SDK, they need to be included in the schema

A working example using sdk.getEventMessages() and sdk.subscribeEventQuery() would be very helpful

@rsodre rsodre added the bug Something isn't working label Dec 6, 2024
@rsodre rsodre mentioned this issue Dec 17, 2024
10 tasks
@glihm
Copy link
Collaborator

glihm commented Dec 17, 2024

Note for me: check if it's at the ABI level (not having event exposed) or just the dojo bindgen common layer that is not doing the job correctly.

@glihm
Copy link
Collaborator

glihm commented Dec 30, 2024

@MartianGreed add events + order them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants