Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong return type for createAgent and startAgent functions #1096

Closed
BlockJuic3 opened this issue Dec 14, 2024 · 0 comments · Fixed by #1097
Closed

Wrong return type for createAgent and startAgent functions #1096

BlockJuic3 opened this issue Dec 14, 2024 · 0 comments · Fixed by #1097
Labels
bug Something isn't working

Comments

@BlockJuic3
Copy link
Contributor

Describe the bug
The createAgent and startAgent functions of the agent package are async, but their response type aren't wrapped in a Promise

To Reproduce
Let the LSP do its job

Expected behavior
To not have an error on the return type of the two functions

Additional context

Declaration of createAgent
https://github.com/ai16z/eliza/blob/67f85fb073a188676c580cffcc36f023e1cc78c1/agent/src/index.ts#L406

Declaration of startAgent
https://github.com/ai16z/eliza/blob/67f85fb073a188676c580cffcc36f023e1cc78c1/agent/src/index.ts#L515
@BlockJuic3 BlockJuic3 added the bug Something isn't working label Dec 14, 2024
@shakkernerd shakkernerd changed the title Wrong return type for createAgente and startAgent functions Wrong return type for createAgent and startAgent functions Dec 14, 2024
@BlockJuic3 BlockJuic3 mentioned this issue Dec 14, 2024
Merged
@AIFlowML AIFlowML closed this as completed Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: return types of createAgent & startAgent BlockJuic3/eliza
2 participants
@AIFlowML @BlockJuic3