Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Starknet plugin proper providers implementation #1912

Open
augustin-v opened this issue Jan 6, 2025 · 1 comment
Open

Starknet plugin proper providers implementation #1912

augustin-v opened this issue Jan 6, 2025 · 1 comment
Labels
enhancement New feature or request

Comments

@augustin-v
Copy link

Is your feature request related to a problem? Please describe.

The starknet plugin package needs a few fix/features especially in the /src/providers folder e.g.:

import { WalletProvider } from "./walletProvider.ts";

Importing a non existent file and the trustScoreProvider functionality not quite there yet.

Describe the solution you'd like

Adapt the plugin to starknet, fix imports and wallet methods calls. See here for example:

// TODO: Update to Starknet
async getTokensInWallet(runtime: IAgentRuntime): Promise<Item[]> {
const walletInfo =
await this.walletProvider.fetchPortfolioValue(runtime);
const items = walletInfo.items;
return items;
}

Instead of .fetchPortfolioValue(), the correct method should likely be
async getWalletPortfolio(): Promise<TokenBalances> {

and the imported Promise<Item> (intoken.ts) is not defined yet.

@augustin-v augustin-v added the enhancement New feature or request label Jan 6, 2025
Copy link
Contributor

github-actions bot commented Jan 6, 2025

Hello @augustin-v! Welcome to the ai16z community. Thank you for opening your first issue; we appreciate your contribution. You are now a ai16z contributor!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant