Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: update format check command to ignore .prettierignore files #787

Merged
merged 1 commit into from
Jun 1, 2024

Conversation

Fallenbagel
Copy link
Owner

Description

This is to try and fix formatting issues on #773 on a file that should be ignored.
The reason why the file was ignored was because locally when yarn format:check was run, it shows as follows:
image

However, the format check action is failing saying that the settings.cypress.json needs prettier run on it.
image

Screenshot (if UI-related)

To-Dos

  • Successful build yarn build
  • Translation keys yarn i18n:extract
  • Database migration (if required)

Issues Fixed or Closed

  • Fixes #XXXX

This is to try and fix formatting issues on #773 on a file
that should be ignored.
@Fallenbagel Fallenbagel merged commit 1f1ad72 into develop Jun 1, 2024
5 checks passed
Fallenbagel added a commit that referenced this pull request Jun 1, 2024
Fallenbagel added a commit that referenced this pull request Jun 1, 2024
@Fallenbagel
Copy link
Owner Author

🎉 This PR is included in version 1.9.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@gauthier-th gauthier-th deleted the ci-format-ignore-path branch August 24, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant