fix: remove DNS caching #837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DNS caching was initially implemented to avoid too many DNS requests, as Node.js does not cache them. However, the cacheable-lookup library we used to implement this cache created more problems than it solved, as it caused many unresolved DNS request errors that weren't occurring before.
Fallenbagel
requested changes
Jun 23, 2024
Fallenbagel
approved these changes
Jun 24, 2024
|
🎉 This PR is included in version 2.0.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
bonswouar
pushed a commit
to bonswouar/jellyseerr
that referenced
this pull request
Nov 10, 2024
* fix: remove DNS caching DNS caching was initially implemented to avoid too many DNS requests, as Node.js does not cache them. However, the cacheable-lookup library we used to implement this cache created more problems than it solved, as it caused many unresolved DNS request errors that weren't occurring before. * fix: add PNPM lock file to Prettier ignore list * revert: prettier on PNPM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
DNS caching was initially implemented to avoid too many DNS requests, as Node.js does not cache them. However, the cacheable-lookup library we used to implement this cache created more problems than it solved, as it caused many unresolved DNS request errors that weren't occurring before.
Screenshot (if UI-related)
To-Dos
yarn buildyarn i18n:extractIssues Fixed or Closed