Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce global dimension constants #159

Open
nyurik opened this issue Aug 12, 2023 · 0 comments
Open

Introduce global dimension constants #159

nyurik opened this issue Aug 12, 2023 · 0 comments

Comments

@nyurik
Copy link
Member

nyurik commented Aug 12, 2023

IMO, the CoordDimensions has a somewhat weird usage pattern: it uses constant functions instead of true consts. Perhaps we should introduce global DIM_XY, DIM_XYZ, etc, same as we currently have in the unit tests, but exposed globally, assuming everyone is OK with the naming. Should we do this?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nyurik