You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I just set up this library with bootstrap custom checkboxes, and everything works fine except the shift click functionality.
After investigating this is probably because onMouseDown checks that the event target has the data-check-all-item attribute, which is not the case as bootstrap hides the input and displays the checkbox in the label's :before and :after pseude-elements, causing the event.target to be the label, which does not have the attribute.
It might happen the same with other CSS libraries that use a similiar approach to change the checkbox design like Semantic UI or iCheck.
I don't know if there is an easy fix or of it is worth it, but in that case it might be required to explain it in the README.
I just set up this library with bootstrap custom checkboxes, and everything works fine except the
shift click
functionality.After investigating this is probably because onMouseDown checks that the event target has the
data-check-all-item
attribute, which is not the case as bootstrap hides the input and displays the checkbox in the label's:before
and:after
pseude-elements, causing theevent.target
to be the label, which does not have the attribute.It might happen the same with other CSS libraries that use a similiar approach to change the checkbox design like Semantic UI or iCheck.
I don't know if there is an easy fix or of it is worth it, but in that case it might be required to explain it in the README.
Here is a simple example so you can see the behaviour I'm describing: https://codesandbox.io/s/githubcheck-all-bootstrap-custom-checkboxes-76jv5
The text was updated successfully, but these errors were encountered: