Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Empty deployment-settings.yml cause error #730

Open
PendaGTP opened this issue Jan 6, 2025 · 0 comments · May be fixed by #731
Open

Empty deployment-settings.yml cause error #730

PendaGTP opened this issue Jan 6, 2025 · 0 comments · May be fixed by #731
Labels
bug Something isn't working

Comments

@PendaGTP
Copy link
Contributor

PendaGTP commented Jan 6, 2025 •
edited
Loading

Problem Description

Currently safe-settings doesn't handle empty deployment-settings.yml and null arrays safely.
This cause runtime errors when the deployment config is loaded/processed.

Proposed solution:

  • Add fallback for empty yaml
  • Add array validation before iteration

Environment

  • safe-settings: 2.1.24
@PendaGTP PendaGTP added the bug Something isn't working label Jan 6, 2025
@PendaGTP PendaGTP linked a pull request Jan 6, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: handle empty deployment config yaml file PendaGTP/safe-settings
1 participant
@PendaGTP