Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restarting vscode while the extension is starting up can remove databases. #1489

Closed
alexet opened this issue Aug 31, 2022 · 0 comments · Fixed by #1638
Closed

Restarting vscode while the extension is starting up can remove databases. #1489

alexet opened this issue Aug 31, 2022 · 0 comments · Fixed by #1638
Labels
bug Something isn't working VSCode

Comments

@alexet
Copy link
Contributor

alexet commented Aug 31, 2022

Describe the bug
Restarting the extension before all databases have been reloaded means we lose the databases that haven't been loaded yet.

Version

CodeQL extension version: 1.6.11
CodeQL CLI version: 2.10.3
Platform: linux x64

To reproduce

  • Start vscode with the extension and add some large databases.
  • Restart vscode.
  • Close it while some but not all databases have been loaded.
  • Reopen it and notice that the databases are missing.

Expected behavior

The databases that weren't loaded were loaded the next time.
@alexet alexet added the bug Something isn't working label Aug 31, 2022
@aeisenberg aeisenberg mentioned this issue Oct 20, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working VSCode
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix bug where dbs are lost on restart github/vscode-codeql
1 participant
@alexet