Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate twitter shortcode in favor of x shortcode #13214

Open
jmooring opened this issue Jan 5, 2025 · 4 comments
Open

Deprecate twitter shortcode in favor of x shortcode #13214

jmooring opened this issue Jan 5, 2025 · 4 comments
Milestone

Comments

@jmooring
Copy link
Member

jmooring commented Jan 5, 2025

The need for this became obvious (at least to me) while working to elevate our embedded shortcode documentation to its own section. They re-branded a while ago, and while the public's transition has been slow, the new brand has been stable for quite a while.

  • Twitter => "X"
  • tweet => "post" or "X post"

This change touches a few things, including:

  • Internal shortcode aliasing (maybe)
  • Replacement and deprecation of privacy config
  • Replacement and deprecation of services config
  • Renaming (or making copies of) the internal templates (twitter and twitter_simple)
  • Updating tests

We'll leave the twitter_cards template alone because, at least for now, the term "Twitter Cards" seems to still be the recognized phrase.

Keep in mind that site and theme authors may have created their own tweet, twitter, or twitter_simple shortcodes, so calling shortcodes by these names should not trigger a warning. We need to handle this on the receiving end (i.e., after we've determined that we're using an embedded shortcode).

I've got a working branch, but will refrain from submitting unless this proposal is approved.

@tohn
Copy link

tohn commented Jan 8, 2025

How about deprecating this altogether?

Maybe we should have a shortcode for the fediverse (e.g. Mastodon) instead of supporting a platform dictated by a right wing multi billionaire 🤔

@stoic-hugo
Copy link

How about deprecating this altogether?

Maybe we should have a shortcode for the fediverse (e.g. Mastodon) instead of supporting a platform dictated by a right wing multi billionaire 🤔

My thoughts are the project should continue to be inclusive and neutral, and strive to prioritize the needs of the community over any political or ideological influence. Ultimately, decisions should be based on functionality and what best serves the community, not political affiliations.

@willfaught
Copy link

Agreed that politics shouldn’t enter the calculation.

I have a vague recollection that Hugo was avoiding adding built-in partials for third-party services in the future.

@bep
Copy link
Member

bep commented Jan 9, 2025

I have a vague recollection that Hugo was avoiding adding built-in partials for third-party services in the future.

This isn't a new service; x is a rebrand of Twitter, and I don't think we have said anything like the above. But the service in question need to be on a grand scale (e.g. Facebook, Twitter), and that is very rare and borderline impossible for new social services. I'm not a fan of Musk's political views, but X is still the leader by a biiig margin in what it does.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants