-
Notifications
You must be signed in to change notification settings - Fork 9.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fully parse input variables from TF_VAR_
when validating during apply
#36121
Conversation
Input variables taken from the environment have no type information, so are initially stored as strings. When we compare those for validation during apply, we have to make sure to use the same parsing logic used in the plan in order to compare them with the stored variables.
Non-string input variables taken from the environment initially need to be parsed and stored as string, since there is no type associated type information. Make sure these are correctly handled when validated during apply.
5997797
to
4883499
Compare
Hey @jbardin thank you for the work! Is there anything blocking from merging? Thanks :) |
Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch. |
has this been merged into the release v1.10? We're still seeing the error but want to make sure its because it simply hasn't been released into the wild yet |
@jonathandbyrd, no there has not yet been a v1.10.1 release yet, but that should be scheduled soon. |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Input variables taken from the environment have no type information, so are initially stored as strings. When we compare those for validation during apply, we have to make sure to use the same parsing logic used in the plan in order to compare them with the stored variables.
Fixes #36106