Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helix integration #1

Open
jerabaul29 opened this issue Sep 29, 2024 · 3 comments
Open

Helix integration #1

jerabaul29 opened this issue Sep 29, 2024 · 3 comments

Comments

@jerabaul29
Copy link

Thank you for this crate - it looks really amazing! :)

Is there a way to use this in helix already / is there a PR or similar on the helix project? If so, could this be linked to either from a pinned issue, and / or from the readme of this repo, to make it easier to find? :)

@the-mikedavis
Copy link
Member

There isn't currently an integration branch in Helix but I opened up helix-editor/helix#11660 with ideas on how the integration should look. There's a branch/commit linked in that issue that has the very very naive integration I use locally helix-editor/helix#11660 (comment)

Currently I'm working on the suggest function as time allows (which is around half way complete) and then I'd look at working on the integration. In the meantime I'll keep this issue pinned and add a link in the README when there's a branch

@the-mikedavis the-mikedavis pinned this issue Oct 1, 2024
@the-mikedavis the-mikedavis changed the title Is there a way to already use this in helix / link to the relevant PR? Helix integration Oct 1, 2024
@jvoisin
Copy link

jvoisin commented Oct 11, 2024

May I suggest an integration via LSP, so that more editors might make use of this?

@the-mikedavis
Copy link
Member

It could be cool to expose this as a language server as well. That's not something I'm interested in working on personally but with changes we have planned for Helix's tree-sitter integration it might be possible to port out the significant parts of the Helix integration and make it a standalone language server usable with other editors.

It might also be possible to use Spellbook in existing language servers like Harper which include their own Hunspell-like internals. (Harper's implementation works a bit differently than Hunspell though - it expands affixes in its main lookup table, same with ZSpell and Vale - so this is probably not a straightforward change.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants