-
-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sending text to FSI is very slow #1412
Comments
Hey @ronaldschlenker 👋, Thank you for opening an issue. We will get back to you as https://opencollective.com/ionide
|
TBF, not sure if we have any impact on this - we just call "send a text to terminal" API from VSCode Maybe @Tyriar can help us with this? |
We made a change recently to fix a long standing issue where sent/pasted text would be truncated microsoft/vscode#38137. The fix was to split up the text into chunks of 50 characters which seems to match your gif. I think now you're hitting a known Windows perf problem as a result of running conpty on the UI thread which is tracked in microsoft/vscode#74620 |
I saw this and tried moving back to the standard terminal renderer - for some reason I was on the DOM one which was super slow. |
I guess it might really be a windows issue. When I send a bunch of text via the "Terminal: Run Selected Text in Active Terminal" to a Windows Powershell Terminal, it is also quite slow (like in the gif above). Now when I run |
@ronaldschlenker which terminal renderer are you using? |
I tried it with all 3 (canvas, dom and WebGL), but there is no significant difference. And I think the issue has definitely something to do with the used console host and maybe the communication with it, since using WSL/bash, it is really fast. |
Ok, I'm closing this one here, as it's nothing we can control/fix anyway. |
Sending text to fsi (can be strings or just code in general) takes a very long time compared to Rider or Visual Studio. You can see the behaviour here:
When sending larger sources to FSI, this can be very annoying and it lowers the "working with data in F#" experience drastically. I don't know where exactly this is coming from. What I can tell is that it makes my use cases almost unusable - sometimes output is even slower than shown in the GIF. This behaviour can also be seen when you run things like this:
...or when you display a response from a webserver.
When I simply send text to a vi (bash) in vscode, the text is displayed immediately.
I know that there was an issue like that here, but I don't find it anymore.
If I can assist you somehow, please let me know.
Hint: This is independent from the usage of .Net 5 preview / .Net 461 / .Net Core version.
The text was updated successfully, but these errors were encountered: