Download default configs when deploying Purpur and Pufferfish

[Krymonota]

Enhancement Type

Improve an existing feature

Describe the enhancement

Since Purpur and Pufferfish are forks of Paper, it would be nice to download the same default configurations as for Paper. They are compatible because Purpur and Pufferfish have separate configuration files (purpur.yml / pufferfish.yml) for fork-specific features.

Essentially, we would simply have to extract this code into a reusable function/script and invoke it from start-deployPaper, start-deployPurpur and start-deployPufferfish.

docker-minecraft-server/scripts/start-deployPaper

Lines 45 to 56 in 621bafb

	defaultTopLevelConfigs="bukkit.yml spigot.yml"
	if versionLessThan 1.19; then
	defaultTopLevelConfigs+=" paper.yml"
	else
	# Download default configs to allow for consistent patching
	DOWNLOAD_DEFAULT_CONFIGS=$(buildDownloadList "$PAPER_CONFIG_DEFAULTS_REPO" "$VERSION" paper-global.yml paper-world-defaults.yml)
	export DOWNLOAD_DEFAULT_CONFIGS
	fi
	# Download top-level configs to allow for consistent patching
	DOWNLOAD_DEFAULTS=$(buildDownloadList "$PAPER_CONFIG_DEFAULTS_REPO" "$VERSION" $defaultTopLevelConfigs)
	export DOWNLOAD_DEFAULTS

And we would have to think about what to do with this environment variable (keep the same name for forks, rename it, ...?):

docker-minecraft-server/scripts/start-deployPaper

Line 13 in 621bafb

: "${PAPER_CONFIG_DEFAULTS_REPO:=${PAPER_CONFIG_REPO:=https://raw.githubusercontent.com/dayyeeet/minecraft-default-configs/main}}"

[itzg]

Great suggestions.

Perhaps for the variable it should be shifted to just CONFIG_DEFAULTS_REPO and used for all of them. The downside I can think is now it could seem applicable to non-Paper derivatives.