Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow changing the default screen mode #400

Closed
Rdkang opened this issue Nov 13, 2022 · 6 comments
Closed

Allow changing the default screen mode #400

Rdkang opened this issue Nov 13, 2022 · 6 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@Rdkang
Copy link
Contributor

Rdkang commented Nov 13, 2022

Is your feature request related to a problem? Please describe.
Most of the time i do not use the images and volumes panel and is unneeded information for me, So It would be great if i could set the default screen mode.

Describe the solution you'd like
An option in config.yml:

gui:
   # options should be: normal,half,fullscreen
   screenMode: "half"
   

Describe alternatives you've considered
An alternative improvement could be being able to toggle panels

@Rdkang Rdkang added the enhancement New feature or request label Nov 13, 2022
@jesseduffield
Copy link
Owner

Works for me. This should be easy to implement: just needs a new config key here and then we need to make use of that when the gui is first opened here and then we gotta update the config doc with the default value here

Would you be up to raise a PR for this @Rdkang ?

@jesseduffield jesseduffield added the good first issue Good for newcomers label Nov 23, 2022
@Rdkang Rdkang closed this as completed Nov 23, 2022
@Rdkang
Copy link
Contributor Author

Rdkang commented Nov 23, 2022

Yes, thank you for the helpful links.
I will try to implement it this weekend

@jesseduffield
Copy link
Owner

Awesome, let me know if you run into any issues.

Also I'll re-open this until the issue is complete

@c0dehu1k
Copy link

c0dehu1k commented Jun 30, 2023

gui:
screenMode: half
options should also include normal,half,full

what is going to be the behaviour for Normal, Half and Full
Let me try to get this fixed :)

@Rdkang
Copy link
Contributor Author

Rdkang commented Jul 14, 2023

Let me try to get this fixed :)

Thank you @c0dehu1k so much for your interest in helping! I wanted to let you know that I've already implemented the code in #421 :).
I've been using this code for the past six months and it's been working flawlessly.

Right now, I'm just waiting for @jesseduffield to review and accept the pull request #421.

@c0dehu1k
Copy link

Super, Thank you @Rdkang for informing me!!
Let me look for another one ;)

@Rdkang Rdkang closed this as completed Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants