Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'graphics-document' is not recognized as valid role #756

Closed
jjoselv opened this issue Nov 17, 2020 · 13 comments
Closed

'graphics-document' is not recognized as valid role #756

jjoselv opened this issue Nov 17, 2020 · 13 comments

Comments

@jjoselv
Copy link

jjoselv commented Nov 17, 2020

Example of use: https://www.w3.org/TR/graphics-aria-1.0/#graphics-document

@ljharb
Copy link
Member

ljharb commented Mar 18, 2022

I believe this is blocked on A11yance/aria-query#181 (comment)

@jrnail23
Copy link

@ljharb This issue appears to be unblocked now, via A11yance/aria-query#338

@ljharb
Copy link
Member

ljharb commented Oct 26, 2022

@jjoselv @jrnail23 can you elaborate on which specific rules you'd like to recognize it?

@ljharb
Copy link
Member

ljharb commented Oct 26, 2022

(This should be unblocked by #814, as well)

@jrnail23
Copy link

@ljharb jsx-a11y/aria-role, in my case

@ljharb
Copy link
Member

ljharb commented Oct 26, 2022

I think this is now blocked on A11yance/aria-query#338 (comment) - otherwise it'd just be passing already.

@jessebeach
Copy link
Collaborator

@ljharb what PR is failing? I don't see one in the list of PRs.

@jessebeach
Copy link
Collaborator

I printed and filtered the roles just to verify that the graphics roles are included in the rolesMap.

console.log(rolesMap.keys().filter(key => /^graphics/.test(key)));

Screen Shot 2022-10-29 at 3 23 03 PM

@ljharb
Copy link
Member

ljharb commented Oct 30, 2022

No PR; just tests i added locally. I verified the version was updated also. I’ll put up a PR later to be sure it’s reproducible.

@ljharb
Copy link
Member

ljharb commented Oct 30, 2022

@jessebeach the tests failed here

@jessebeach
Copy link
Collaborator

I see. I'll investigate.

@jessebeach
Copy link
Collaborator

@ljharb I just published v5.1.3 and your code passes on it. No code changes, just a new publish. This is the second time I've seen NPM mess up a package in the past few weeks.

console.log __tests__/src/rules/aria-role-test.js:28
    [ 'graphics-document', 'graphics-object', 'graphics-symbol' ]

@ljharb
Copy link
Member

ljharb commented Oct 31, 2022

Thanks! Pushing passing tests to close.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants