Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enter "incremental" mode if a query returns more than "incrementalBufferRows" #251

Closed
julianhyde opened this issue Jan 7, 2019 · 1 comment
Closed

Enter "incremental" mode if a query returns more than "incrementalBufferRows" #251

julianhyde opened this issue Jan 7, 2019 · 1 comment

Comments

@julianhyde
Copy link
Owner

Enter "incremental" mode if a query returns more than "incrementalBufferRows". "incrementalBufferRows" would be a new parameter, default value 1,000.

With this change, and assuming that the session is in non-incremental mode, small queries would be nicely formatted, and large queries would not consume too much memory and would not pause too long before starting to output results.

See https://issues.apache.org/jira/browse/HIVE-14170; we could possibly apply the same change.

Related: #228.
@julianhyde julianhyde mentioned this issue Jan 7, 2019
Closed
@snuyanzin snuyanzin mentioned this issue Jan 15, 2019
Closed
@julianhyde
Copy link
Owner Author

Fixed 19ea58e (thanks for PR #262, @snuyanzin!), with a further enhancement in 0eda7e0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[SQLLINE-251] Implementation of entering "incremental" mode if a quer… snuyanzin/sqlline
1 participant
@julianhyde