Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move connection close statement to debug level #337

Closed
arina-ielchiieva opened this issue Aug 4, 2019 · 1 comment
Closed

Move connection close statement to debug level #337

arina-ielchiieva opened this issue Aug 4, 2019 · 1 comment

Comments

@arina-ielchiieva
Copy link
Collaborator

When closing connection, closing information is displayed at output level.

apache drill> !quit
Closing: org.apache.drill.jdbc.impl.DrillConnectionImpl

I am not sure if this information is useful for the user and has any value.
This ticket suggests to move connection related information to debug level.
Why info level is not suggested?
Because if we use info level such information still be displayed unless !set silent true is set. But when setting !set silent true, other more useful information will be hidden, for example, number of rows displayed and elapsed time 1 row selected (1.778 seconds) thus suggested level is debug.

@snuyanzin
Copy link
Collaborator

Merged as a63de2a

Thanks, @arina-ielchiieva

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants