Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Support Multipolygons #114

Open
FriederHannenheim opened this issue Jan 1, 2025 · 2 comments
Open

[FEATURE] Support Multipolygons #114

FriederHannenheim opened this issue Jan 1, 2025 · 2 comments
Labels
feature Feature request

Comments

@FriederHannenheim
Copy link

FriederHannenheim commented Jan 1, 2025

Is your feature request related to a problem? Please describe.
Certain map features, entered as multipolygons are not rendered. For example this forest in a park in Dresden: https://www.openstreetmap.org/relation/421481

Describe the solution you'd like
Multipolygons need to be supported and rendered like other features

EDIT: After looking at the code it looks like Multipolygons may already be supported. If so, this issue is now a bug report.

To Reproduce

Generate a world using this command

cargo r -- --bbox="13.709221,51.033622,13.771019,51.071605" --path=<world path>

Run the following command in Minecraft:

/tp @p 3127 -61 3447

You are now at this fountain: https://www.openstreetmap.org/node/248204401

Which is surrounded by the forest linked above. You will see that the forest is not rendered in Minecraft.

@FriederHannenheim FriederHannenheim added the feature Feature request label Jan 1, 2025
@louis-e
Copy link
Owner

louis-e commented Jan 1, 2025

Hi there!
Sorry for the late response, this project exploded in popularity right before I planned my vacation. :D

Thank you for the report, I'll take care of fixing this as soon as possible. I remember some problems in the past we had with multipolygon elements, so this sounds plausible and should hopefully be fixed quickly!

Have an amazing start into the new year!

@louis-e
Copy link
Owner

louis-e commented Jan 4, 2025

Alright, back at it again! I now implemented multipolygon support for buildings with #165. Will be included in the next release. However, the floodfill algorithm will have a lot of struggles with this shape :D
image

I think it'll take a bit of time until we get to fix this exact park element. I'm already thinking about how to do it, it's not quite easy.

Grüße nach Dresden, dort war ich bis gestern noch! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Feature request
Projects
None yet
Development

No branches or pull requests

2 participants