Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test broken #90

Closed
RuiSiang opened this issue May 8, 2020 · 1 comment
Closed

Test broken #90

RuiSiang opened this issue May 8, 2020 · 1 comment

Comments

@RuiSiang
Copy link

RuiSiang commented May 8, 2020 •
edited
Loading

Saw drqwerty coming up with a nice rotate option PR #84 , but it doesn't seem to merge properly. Any updates on that? Should be a problem with canvas installation. Thanks

npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! [email protected] install: `node-gyp rebuild`
npm ERR! Exit status 1

Should be a problem with .travis.yml
@lukechilds
Copy link
Owner

lukechilds commented May 8, 2020 •
edited
Loading

Tests are currently working in master: https://travis-ci.org/github/lukechilds/merge-images/builds/662960617

merge-images has changed since that PR was opened. We only support node-canvas v2 now.

The PR will need to be rebased from master before being merged.

@lukechilds lukechilds mentioned this issue May 8, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lukechilds @RuiSiang