Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port kernel extension API to web #9585

Closed
rchiodo opened this issue Apr 4, 2022 · 7 comments
Closed

Port kernel extension API to web #9585

rchiodo opened this issue Apr 4, 2022 · 7 comments
Assignees
Labels
debt Code quality issues

Comments

@rchiodo
Copy link
Contributor

rchiodo commented Apr 4, 2022

Web extensions will likely need support for the kernel API too

@rchiodo rchiodo added the bug Issue identified by VS Code Team member as probable bug label Apr 4, 2022
@rchiodo
Copy link
Contributor Author

rchiodo commented Apr 4, 2022

Here's the current api:

export interface IExportedKernelService {

@DonJayamanne
Copy link
Contributor

Web extensions will likely need support for the kernel API too

Yup, that's how I've built the powertoys extension. I.e. with the plan we will web-enable that extension as well.

@lostintangent
Copy link
Member

Would this API enable an extension to provision a remote Jupyter kernel (e.g. within a GitHub Codespace), and then provide the server URL, so that the Jupyter extension could handle the communication between VS Code and Jupyter?

@DonJayamanne
Copy link
Contributor

extension to provision a remote Jupyter kernel

No, at this stage there's no such plan for this extension to provision Jupyter.
This API merely provides a 3rd party extension to communicate with existing kernels.

I believe something similar is being addressed in the VS Code iteration plan here Explore support for proxy controllers

@rchiodo
Copy link
Contributor Author

rchiodo commented Apr 4, 2022

@DonJayamanne I believe @lostintangent will be using the proxy controller support, but then as a secondary step, they want to provide us with the URI to connect to.

@lostintangent it sounds like you want something like so?

export interface IJupyterExtension {
   provideServerUri(uri: URI);
}

That would be the same as the user picking a remote server in the jupyter extension today? Maybe we could handle that with the current command we already have. In fact a user added that extensibility already:

f9329d6

Essentially another extension just executes a command to set a jupyter server URI.

So @lostintangent I believe this is already supported.

@lostintangent
Copy link
Member

Yep, something like what you mentioned should work well! That way, we could register the kernel controllers with VS Code, and when selected, provision the Codespace compute, start up Jupyter on it, and then automate connecting the Jupyter client to it.

@greazer greazer added vscode-web debt Code quality issues and removed needs-triage bug Issue identified by VS Code Team member as probable bug debt Code quality issues labels Apr 7, 2022
@DonJayamanne DonJayamanne self-assigned this Aug 15, 2022
@DonJayamanne DonJayamanne added debt Code quality issues and removed iteration-candidate labels Dec 5, 2022
@DonJayamanne
Copy link
Contributor

Hasn't been requested by any users, closing this issue for now

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debt Code quality issues
Projects
None yet
Development

No branches or pull requests

4 participants