Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can approve multiple times #317

Closed
alexdima opened this issue Aug 29, 2018 · 2 comments
Closed

Can approve multiple times #317

alexdima opened this issue Aug 29, 2018 · 2 comments
Labels
under-discussion Issue is under discussion for relevance, priority, approach

Comments

@alexdima
Copy link
Member

alexdima commented Aug 29, 2018 •
edited
Loading

Testing microsoft/vscode#57301

  • open a PR
  • click Approve again and again...
@RMacfarlane
Copy link
Contributor

This is the same behavior as GitHub - they have no restriction on approving a PR multiple times from their UI.

@RMacfarlane RMacfarlane added the under-discussion Issue is under discussion for relevance, priority, approach label Aug 29, 2018
@alexdima
Copy link
Member Author

Ok. Weird :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
under-discussion Issue is under discussion for relevance, priority, approach
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@RMacfarlane @alexdima