Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Readable types are incorrect #121

Open
phated opened this issue Sep 25, 2023 · 1 comment
Open

Readable types are incorrect #121

phated opened this issue Sep 25, 2023 · 1 comment
Labels
bug Issue identified by VS Code Team member as probable bug
Milestone
Backlog

Comments

@phated
Copy link

phated commented Sep 25, 2023

As a follow up to #119, I discovered that the Readable stream's data is not always a Uint8Array, but is sometimes a SharedArrayBuffer. I believe this occurs when running an extension in the browser.

This is a problem because you can't TextDecoder#decode a SharedArrayBuffer, so my shims needed to copy the contents into a new Uint8Array before passing them onward.
@dbaeumer
Copy link
Member

We should definitely make this consistent. I know that I do some copying tricks because of the decode.

@dbaeumer dbaeumer added the bug Issue identified by VS Code Team member as probable bug label Dec 18, 2024
@dbaeumer dbaeumer added this to the Backlog milestone Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Issue identified by VS Code Team member as probable bug
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
2 participants
@phated @dbaeumer